- From: Matt Falkenhagen <notifications@github.com>
- Date: Tue, 25 Jun 2019 07:02:06 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 25 June 2019 14:02:28 UTC
This is an interesting idea. It may help to see a real example in practice. However, I’m kind of leaning toward the second example in https://github.com/whatwg/infra/issues/257 (the 7 step one with step 6 being “If aborted”) as being OK. It would seem to match typical implementation code more closely. E.g., we have ServiceWorkerRegisterJob::Abort (https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_register_job.cc?l=134&rcl=42482d4f5324ceefe37d7a84777c53febfcf4efa) which has to go through and clean up any half-baked state in one sequential set of steps. Though a better implementation might have done this differently. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1443#issuecomment-505458858
Received on Tuesday, 25 June 2019 14:02:28 UTC