Re: [whatwg/encoding] Review Draft Publication: June 2019 (#177)

> This is failing, I think because of validator warnings on the encoding tables. /cc @sideshowbarker to verify that warnings about Unicode normalization forms would cause a build failure.

It’s failing for the warnings because in https://github.com/whatwg/whatwg.org/blob/17fbe5071c59194dec4ce9442fc3ab1749052cb8/resources.whatwg.org/build/deploy.sh#L186-L190 we explicitly give the `--Werror` argument in the checker invocation:

```bash
    if [ -z "$CHECKER_FILTER" ]; then
      ./vnu-runtime-image/bin/vnu --skip-non-html --Werror "$WEB_ROOT"
    else
      ./vnu-runtime-image/bin/vnu --skip-non-html --Werror --filterpattern "$CHECKER_FILTER" "$WEB_ROOT"
    fi
```

That causes warnings to be treated as errors; so if there are any warnings, the process exits non-zero.

But as I mentioned in https://github.com/whatwg/encoding/issues/178#issuecomment-503412109, I think we can work around this by making the checker suppress/filter out those warnings.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/177#issuecomment-503413588