Re: [w3c/ServiceWorker] Bikeshed improvements to *force bypass cache for import scripts flag* (#1430)

jakearchibald approved this pull request.

Just a couple of nits

> @@ -935,7 +935,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
       };
     </pre>
 
-    A {{ServiceWorkerGlobalScope}} object represents the global execution context of a [=/service worker=]. A {{ServiceWorkerGlobalScope}} object has an associated <dfn for="ServiceWorkerGlobalScope">service worker</dfn> (a [=/service worker=]). A {{ServiceWorkerGlobalScope}} object has an associated <dfn for="ServiceWorkerGlobalScope">force bypass cache for importscripts flag</dfn>. It is initially unset.
+    A {{ServiceWorkerGlobalScope}} object represents the global execution context of a [=/service worker=]. A {{ServiceWorkerGlobalScope}} object has an associated <dfn for="ServiceWorkerGlobalScope">service worker</dfn> (a [=/service worker=]). A {{ServiceWorkerGlobalScope}} object has an associated <dfn for="ServiceWorkerGlobalScope">force bypass cache for import scripts flag</dfn>. It is a flag that is initially unset.

"It is initially unset" is fine. The name already includes "flag", and that seems to be good enough (from looking at other specs).

> @@ -2600,9 +2600,9 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
 
       : Input
       :: |registration|, a [=/service worker registration=]
-      :: *force bypass cache flag*, an optional flag unset by default
+      :: |force bypass cache flag|, an optional flag unset by default

We don't tend to have spaces in variable names. Also, we tend to use booleans rather than flags in variables (last I heard, the plan is to move away from flags altogether, but I'm not sure what the status of that is).

So `:: |forceBypassCache|, an optional boolean, false by default`?

> @@ -2742,7 +2742,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
 
       : Input
       :: |serviceWorker|, a [=/service worker=]
-      :: *force bypass cache for importscripts flag*, an optional flag unset by default
+      :: |force bypass cache for import scripts flag|, an optional flag unset by default

As above

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1430#pullrequestreview-247522031