- From: Jungkee Song <notifications@github.com>
- Date: Wed, 05 Jun 2019 21:11:53 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 6 June 2019 04:12:15 UTC
jungkees commented on this pull request. > @@ -3007,7 +3005,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe 1. If |registration| is null, then: 1. Invoke <a>Resolve Job Promise</a> with |job| and false. 1. Invoke <a>Finish Job</a> with |job| and abort these steps. - 1. Set |registration|'s <a>uninstalling flag</a>. + 1. [=map/Remove=] [=scope to registration map=][|job|'s [=job/scope url=]]. 1. Invoke <a>Resolve Job Promise</a> with |job| and true. 1. Invoke [=Try Clear Registration=] with |registration|. That sounds reasonable. I agree "unclaim" is a separate issue we can discuss, if necessary. I am fine with Unregister using Try Clear Registration as in this PR too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1415#discussion_r291014837
Received on Thursday, 6 June 2019 04:12:15 UTC