Re: [w3c/screen-orientation] Editorial: Edits to sections 3.2-3.5 (#140)

marcoscaceres approved this pull request.

Couple of suggestions, wdyt? 

> @@ -170,7 +171,7 @@ <h2>
       </section>
       <section>
         <h2>
-          <dfn>type</dfn> attribute
+          <dfn>type</dfn> attribute: Current screen orientation

```suggestion
          <dfn>type</dfn> attribute: Get current orientation
```

> @@ -180,24 +181,24 @@ <h2>
       </section>
       <section>
         <h2>
-          <dfn>angle</dfn> attribute
+          <dfn>angle</dfn> attribute: Current orientation angle

```suggestion
          <dfn>angle</dfn> attribute: Get orientation angle
```

> @@ -207,12 +208,13 @@ <h2>
       </section>
       <section>
         <h2>
-          <dfn>onchange</dfn> attribute
+          <dfn>onchange</dfn> attribute: Handle change events

```suggestion
          <dfn>onchange</dfn> attribute: Handle orientation changes
```

> @@ -152,15 +152,16 @@ <h2>
       </section>
       <section>
         <h2>
-          <dfn>unlock()</dfn> method
+          <dfn>unlock()</dfn> method: Unlock the screen to its default

```suggestion
          <dfn>unlock()</dfn> method: Unlock screen to default orientation
```

> @@ -142,7 +142,7 @@ <h2>
         </pre>
       <section>
         <h2>
-          <dfn>lock()</dfn> method
+          <dfn>lock()</dfn> method: Lock the screen to a specific orientation

```suggestion
          <dfn>lock()</dfn> method: Lock screen to a specific orientation
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/140#pullrequestreview-196809091

Received on Tuesday, 29 January 2019 04:14:41 UTC