Re: [heycam/webidl] Fix error handling around Call(). (#618)

domenic requested changes on this pull request.



> @@ -12151,7 +12151,7 @@ must exist on |A|’s [=interface prototype object=]:
         1.  Let |valueIDL| be the result of [=converted to an IDL value|converting=] |valueArg| to an IDL value of type |valueType|.
         1.  Let |key| be the result of [=converted to ECMAScript values|converting=] |keyIDL| to an ECMAScript value.
         1.  Let |value| be the result of [=converted to ECMAScript values|converting=] |valueIDL| to an ECMAScript value.
-        1.  [=!=] <a abstract-op>Call</a>(|function|, |map|, «|key|, |value|»).
+        1.  Perform [=!=] <a abstract-op>Call</a>(|function|, |map|, «|key|, |value|»).

This should be ?, like the other Map methods, since we're getting arbitrary user code. But, that's all quite broken, as #207 notes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/618#pullrequestreview-197265993

Received on Monday, 28 January 2019 21:24:29 UTC