- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 28 Jan 2019 13:20:37 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 28 January 2019 21:20:59 UTC
domenic approved this pull request.
LGTM with editorial tweak.
> @@ -5939,7 +5943,8 @@ refer to a type whose values are the set of strings (sequences of
Like {{DOMString}}, there is no way to represent a constant [=enumeration=]
value in IDL, although enumeration-typed [=dictionary member=]
-[=dictionary member/default values=] can be specified using a
+and [=optional argument|operation optional argument=] default values
This reads confusingly to me; it's not clear the "default values" distributes over the two preceding constructs. I suggest just distributing it manually, i.e. "enumeration-typed dictionary member default values and operation optional argument default values". That way you can also link to the correct "default values" in both cases.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/621#pullrequestreview-197264600
Received on Monday, 28 January 2019 21:20:59 UTC