Re: [whatwg/fullscreen] Remove from top layer synchronously for not connected elements (#128)

I would definitely be nice if we can fix the issue of double-calling to `exitFullscreen`, but leaving in such state isn't really the first thing I noticed.

With the double-calling `exitFullscreen` issue gets fixed, this approach is still a bit odd that: if you have two fullscreen elements and you remove one, you end up fully exit fullscreen, but if you have three, you end up being left in fullscreen. People (maybe library authors?) may start depending on removing element to fully unfullscreen (since in majority of cases it does), but then it breaks in some rare cases when there are more than three fullscreen elements.

> The main problem with #126 is poking at the state of other frames synchronously, and it can't be implemented exactly like that in Chromium. Doing #65 would resolve the problem, making "fully exit fullscreen" more async.

It's not completely clear to me how #65 would make things better... Do you mean moving more stuff into the async part would make it easier to implement in Chrome? I guess I'm fine with something like, invoke fully exit fullscreen asynchronously when the element gets removed... Would that resolve your problem?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/128#issuecomment-391666430

Received on Thursday, 24 May 2018 10:29:36 UTC