Re: [whatwg/fullscreen] Remove from top layer synchronously for not connected elements (#128)

> When you have two fullscreen elements in the top layer, and you remove one of them, you would end up making the browser window still in fullscreen, but the document has exited the fullscreen state.

This is a variation on the problem of calling `document.exitFullscreen()` twice, where neither call thinks it will end up fully exiting in their synchronous steps, but when the async steps of both have run the top layer is empty. The fix for this has to be in the async part of "exit fullscreen". Seems like there's no bug tracking this, and it's just a TODO in the Chromium code. (It just stays in fullscreen in a weird state.)

> So I still think it is easier to just fully exit fullscreen in this case.

For some redefinition of "fully exit fullscreen" I think that would be fine, although if we fix the above problem that seems slightly nicer to me.

The main problem with https://github.com/whatwg/fullscreen/pull/126 poking at the state of other frames synchronously, and it can't be implemented exactly like that in Chromium. Doing https://github.com/whatwg/fullscreen/pull/65 would resolve the problem, making "fully exit fullscreen" more async. As part of that we'd have to make sure that setting `resize` to true fully and correctly cleans up all state, even if we're in some odd state.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/128#issuecomment-391657911

Received on Thursday, 24 May 2018 09:56:21 UTC