- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 22 May 2018 10:18:57 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 22 May 2018 17:19:21 UTC
domenic approved this pull request.
LGTM, sorry for delay!
> @@ -1826,6 +1826,7 @@ nothrow>ReadableStreamDefaultControllerShouldCallPull ( <var>controller</var> )<
1. If ! IsReadableStreamLocked(_stream_) is *true* and ! ReadableStreamGetNumReadRequests(_stream_) > *0*, return
*true*.
1. Let _desiredSize_ be ReadableStreamDefaultControllerGetDesiredSize(_controller_).
While here can you add a `!`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/926#pullrequestreview-122269268
Received on Tuesday, 22 May 2018 17:19:21 UTC