- From: Adam Rice <notifications@github.com>
- Date: Fri, 18 May 2018 05:25:49 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 18 May 2018 12:26:12 UTC
ReadableStreamDefaultControllerShouldCallPull implicitly assumes that desiredSize is not null when it compares it to 0. This is guaranteed by the check of ReadableStreamDefaultControllerCanCloseOrEnqueue(controller), but it's not obvious. Add an assert to make it explicit. Also do the same for ReadableByteStreamControllerShouldCallPull. No functional changes. Closes #919. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/926 -- Commit Summary -- * ShouldCallPull: Assert desiredSize is not null -- File Changes -- M index.bs (5) M reference-implementation/lib/readable-stream.js (5) -- Patch Links -- https://github.com/whatwg/streams/pull/926.patch https://github.com/whatwg/streams/pull/926.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/926
Received on Friday, 18 May 2018 12:26:12 UTC