- From: Adam Rice <notifications@github.com>
- Date: Tue, 01 May 2018 00:18:07 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 1 May 2018 07:18:31 UTC
I have a tentative plan for this: 1. Move tests that are relevant to both types to a new directory, readable-streams-bikeshed. "relevant" usually means that the test result doesn't depend on the chunk type. For example, move the test `'ReadableStream instances should have the correct list of properties'` from readable-stream/general.js to a new file named readable-streams-bikeshed/general.js. 2. Modify the moved tests to use Uint8Array chunks. Probably defining chunks named `a` and `b` at the top of the file and replacing `"a"` with `a`, etc. would work in most cases. 3. Wrap all the tests in the file in a loop like `for (const type of [undefined, 'bytes'])` 4. [optional] Check if readable-byte-streams/ contains duplicates of the copied tests and if so remove them. This is important to make sure byte streams are rock-solid, but is a tremendous amount of work. Volunteers welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/217#issuecomment-385614628
Received on Tuesday, 1 May 2018 07:18:31 UTC