Re: [heycam/webidl] A dictionary inheriting from a non-JSON type can't be a JSON type. (#571)

domenic approved this pull request.

I think there's a general issue where it's unclear whether "dictionary members" includes inherited or not. Most sentences that use the term in https://heycam.github.io/webidl/#idl-dictionaries align more with the idea of inclusion, e.g.

> A dictionary is a definition (matching Dictionary) used to define an ordered map data type with a fixed, ordered set of entries, termed dictionary members, where keys are strings and values are of a particular type specified in the definition.

or

> The order of the dictionary members on a given dictionary is such that inherited dictionary members are ordered before non-inherited members, and...

As such I'd suggest phrasing this as "(including inherited members)" instead "and inherited members".



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/571#pullrequestreview-137160965