Re: [whatwg/streams] WritableStream: clear algorithms once they will no longer be called (#940)

MattiasBuelens commented on this pull request.



> @@ -919,6 +929,9 @@ function WritableStreamDefaultControllerProcessWrite(controller, chunk) {
       WritableStreamDefaultControllerAdvanceQueueIfNeeded(controller);
     },
     reason => {
+      if (stream._state === 'writable') {

This check does not appear [in the spec text](https://streams.spec.whatwg.org/commit-snapshots/323223e65455e1f22be656b01fe2d810902db2ac/#writable-stream-default-controller-process-write). I believe it should be removed from the reference implementation?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/940#pullrequestreview-137090441

Received on Friday, 13 July 2018 15:49:25 UTC