- From: Jonathon Kereliuk <notifications@github.com>
- Date: Fri, 15 Sep 2017 19:57:17 +0000 (UTC)
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/permissions/pull/151/review/63147400@github.com>
JKereliuk commented on this pull request. > + <li>Let |settings| be the <a>current settings object</a>.</li> + <li>If |settings| is a <a>non-secure context</a> and + <code>|rootDesc|.{{PermissionDescriptor/name}}</code> isn't <a>allowed in + non-secure contexts</a>, return <a>error</a> with <a>error code</a> + <a>invalid argument</a>.</li> + <li>Let |state| by the result of <a>getting the property</a> "`state`" + from the |parameters| argument.</li> + <li>If |state| is neither "`granted`", "`prompt`", nor "`denied`", return + <a>error</a> with <a>error code</a> <a>invalid argument</a>.</li> + <li>Let |allRealms| be the result of <a>getting the property</a> + "`allRealms`" from the |parameters| argument.</a></li> + <li>If |allRealms| is `undefined`, let |allRealms| be false.</li> + <li>If |allRealms| is neither true nor false, return <a>error</a> with + <a>error code</a> <a>invalid argument</a>.</li> + <li>Interpret the value of |state| as <a>new information about the user's + intent</a>. If |allRealms| is true, this information applies to other If I understand correctly, this is the line that actually intends one to change the permissions, specifically it says to add "new information about the user's intent". If I was implementing this as someone who knows WebDriver, but not permissions, I would have to dig through the permissions spec and figure out what this new information actually means and how I can update it. Perhaps be more specific and reference other parts of the API in this part? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/permissions/pull/151#pullrequestreview-63147400
Received on Friday, 15 September 2017 19:58:01 UTC