Re: [w3c/ServiceWorker] (WIP) Navigation preload (#983)

mattto commented on this pull request.



> +  <section dfn-for="NavigationPreloadManager">
+    <h3 id="navigation-preload-manager">{{NavigationPreloadManager}}</h3>
+
+    <pre class="idl">
+      [SecureContext, Exposed=(Window,Worker)]
+      interface NavigationPreloadManager {
+        Promise&lt;void&gt; enable();
+        Promise&lt;void&gt; disable();
+        Promise&lt;void&gt; setHeaderValue(DOMString value);
+        Promise&lt;NavigationPreloadState&gt; getState();
+      };
+    </pre>
+    <pre class="idl" id="navigation-preload-state">
+      dictionary NavigationPreloadState {
+        boolean enabled = false;
+        DOMString headerValue;

Should this be ByteString? The Fetch and XHR specs are using ByteString for HTTP header values.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/983#pullrequestreview-3243891