- From: Adam Rice <notifications@github.com>
- Date: Thu, 06 Oct 2016 21:36:52 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Friday, 7 October 2016 04:37:27 UTC
ricea commented on this pull request. > @@ -0,0 +1,43 @@ +'use strict'; + +self.getterRejects = (t, obj, getterName, target) => { I would prefer assertGetterRejects(), to make it clear that this is an assertion. I thought about assert_getter_rejects(), but then people might expect to find the definition in testharness.js. I realise that testharness's "promise_rejects" doesn't include "assert", but I find that a bit counter-intuitive to be honest. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/512#pullrequestreview-3243830
Received on Friday, 7 October 2016 04:37:27 UTC