- From: Jungkee Song <notifications@github.com>
- Date: Thu, 21 Jan 2016 22:29:58 -0800
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
Received on Friday, 22 January 2016 06:30:40 UTC
Ah.. I had to give this pointer: https://github.com/slightlyoff/ServiceWorker/commit/3d0ee145e27bcaf725ae3050759893c2daf3e363#commitcomment-14237642. To sum, it'd be nice if you review whether this change makes sense: * Before: a queued task (to the client's event loop) captures the window's state and create a WindowClient object **there** and resolves the returned promise **there**. * After: a queued task (to the client's event loop) captures the window's state and only **set the corresponding variables defined in the service worker environment**. When the task has executed, the steps **in the service worker environment** create a WindowClient object and resolves using the values set in the variables. I think `WindowClient.focus()` is an example that I want you to take a look: * Before: https://www.w3.org/TR/2015/WD-service-workers-20150625/#client-focus * After: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#client-focus-method --- Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/672#issuecomment-173824216
Received on Friday, 22 January 2016 06:30:40 UTC