- From: Jungkee Song <notifications@github.com>
- Date: Tue, 16 Feb 2016 19:50:28 -0800
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
- Message-ID: <slightlyoff/ServiceWorker/pull/835/c185005013@github.com>
> through the W3C link checker; all remaining errors there seem to be pretty benign. Nit: 1 occurrence of `<af for="url">origin</a>` in the source files. > added all of them to the "Ignored Terms" section in the bikeshed metadata, which should make it relatively straight forward to figure out what things need fixing. Great. It'd be useful when fixing the related parts. > sections that are auto-generated by bikeshed have different IDs (so #about, #dependencies and #introduction no longer exist) #about and #dependencies got new section ids in conformance sections, so no problem. For #introduction, we might want to make the section name and the section id be consistent. I think "Motivations" is more relevant here. > the pre-bikeshed version had unique IDs auto-generated for every single paragraph in the spec (of the form "header-id.1", "header-id.2", etc. I don't think we need them any more. > Some references now link to equivalent definitions in a different spec That's fine and better for now I think. We might have to sort them out when going for a CR publication later though. > Chrome has a bug (http://crbug.com/431867) which causes it to incorrectly render the <th> elements with the default bikeshed stylesheet Not an issue. Let's defer to the resolution of the issue there. > I think I'd prefer to just squash all these commits together and push the resulting commit Agreed. > There is still room for improvement in how things are dealt with within the spec, but I think this conversion is good enough to replace the spec and any other improvements can be made later. Sure. > @jungkees not sure how carefully you want to review this/how much you trust I didn't make any mistakes; I guess let me know if/when you want me to merge this (squashed or not). LGTM. Please merge them (squashed)! Great to have you as a co-editor. Thanks a lot! --- Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/pull/835#issuecomment-185005013
Received on Wednesday, 17 February 2016 03:50:59 UTC