Re: [slightlyoff/ServiceWorker] Install algorithm step 14 should clear waiting worker before updating state to redundant (#851)

I'm not sure its correct to queue a microtask across thread boundaries like that, is it?

I think it would be simpler to "queue a task to run Resolve Job Promise".  We're already in a separate task from the scheduling of the job, so the extra event loop turn should be non-observable to the script.  It would let use keep using normal tasks for other things, though.

One other nit.  I think Step 19 should only run the Update Worker State algorithm for redundantWorker if redundantWorker is not null.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/851#issuecomment-214777236

Received on Tuesday, 26 April 2016 15:09:58 UTC