Re: [slightlyoff/ServiceWorker] Install algorithm step 14 should clear waiting worker before updating state to redundant (#851)

> One other nit. I think Step 19 should only run the Update Worker State algorithm for redundantWorker if redundantWorker is not null.

Addressed: 50f6d3bb8e9923e8c5eaf2978236901a48296957

> I'm not sure its correct to queue a microtask across thread boundaries like that, is it?

I think queuing a microtask from a parallel algorithm thread to a main thread makes sense. To me, "queue a task to run Resolve Job Promise" rather sounds a bit odd as the reason why promise settlement callback uses a microtask is to run the callback immediately before running the next task in the queue. Using a microtask to change the registration/service worker state seems like a good fit where the changed states can be immediately observed by subsequent tasks (and microtasks).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/851#issuecomment-214957567

Received on Wednesday, 27 April 2016 03:05:12 UTC