Re: Approving new reviewers?

On 25/01/2015 09:16 , James Graham wrote:
> On 24/01/15 23:23, Brad Hill wrote:
>>   Would it be possible to add Yan Zhu and Devdatta Akhawe as reviewers
>> for the WebAppSec portions of web-platform-tests? (currently
>> /subresource-integrity,  /content-security-policy and /cors)
>>
>> Dev is @devd on github, Yan is @diracdeltas
>
> This doesn't need any sort of formal approval to do reviews. They just
> need to set up critic filters for the given directories following the
> instructions at [1].
>
> If you also want them to be able to merge PRs then someone with admin
> permissions for the repository — let's call that person "Mike" — will
> need to add them as members.

I like the name "Mike". It's got a sweet ring to it. So I went ahead and 
granted them both the rights to merge as well as to trigger PR syncs.

-- 
Robin Berjon - http://berjon.com/ - @robinberjon

Received on Sunday, 25 January 2015 07:23:22 UTC