Re: Adding the testharness.js subrepo to the csswg-test repo

On Wednesday, October 16, 2013 at 10:30 PM, Peter Linss wrote:
> On Oct 16, 2013, at 12:53 PM, Tobie Langel <tobie@w3.org (mailto:tobie@w3.org)> wrote:
> > On Oct 16, 2013, at 20:59, Peter Linss <peter.linss@hp.com (mailto:peter.linss@hp.com)> wrote:
> 
> > > In other words, we wouldn't get the automatic updating of the resources directory, as we do know by leaving them separate. Is this what's really wanted?
> > 
> > Yes, for consistency with the main repo.
> 
> I have no issue with keeping the csswg repo consistent with the main repo. But then we need to know which version of the resources repo the main is using to keep in sync. 
> 
> Is there a system for notifications when this changes? or perhaps a tag in the resources repo that we can automatically sync to?
> 
> We also serve a copy of the resources repo at http[s]://test.csswg.org/resources (http://test.csswg.org/resources) so that references in the tests work. I also need to be able to keep that in sync with the version referred to in WPT rather than the tip.
You might want to track the main repo fro changes to `resources`.
> > > I haven't seen any discussion about making the resources directory a submodule in the main WPT repo, so I'm not sure what the goals of this change are.
> > 
> > It's been a submodule on the main repo for a while now.
> 
> That doesn't answer my question.
> 
> Was this done only so that people working on local clones of WPT (sort of) automatically get the resources directory? or is there something more to it?
I'm not sure what you mean by this outside of regular git tools (described in a pull request for the doc[1]).
> e.g.: Has there also been a change in the way testharness.js gets used?

No. 
> i.e. is it sill always '/resources/testharness.js' or are relative urls now allowed too?

No, still absolute only.
> Is the expectation now that the resources directory is included in a packaged test suite? Remember that not all test suites are simple clones of the WPT repo...

We don't have a notion of packaged test suite on the main repo, so I'm not sure what you mean by this.
> These kinds of changes have implications and it would be nice if there was some discussion about them before they happened (and if there was, please point me to the forum that I'm missing), and the decision was communicated more broadly... (like in this mailing list)

I'm not sure I understand what changes you're referring to. Testharness was always in the resources dir. Previously, you had to add it by hand, now it just gets pulled in automatically by adding the --recursive option to the repository clone.

Sorry for not being more helpful. :(

--tobie

---  
[1]: https://github.com/w3c/testtwf-website/pull/162

Received on Wednesday, 16 October 2013 22:09:11 UTC