- From: Laurens Rietveld <laurens.rietveld@vu.nl>
- Date: Wed, 20 Sep 2017 11:12:11 +0200
- To: Ruben Taelman <ruben.taelman@ugent.be>
- CC: RDF-JS <public-rdfjs@w3.org>
- Message-ID: <CAKjXa4OFzhwgJD36FNHZXd8pk2XDi4gv=Wg=Ada2tv2f0Vx2xA@mail.gmail.com>
I like it, good initiative. Using Typescript myself extensively as well. A technical comment: what about making the types a bit stricter. I.e., instead of `termType: string`, using `termType: 'NamedNode' | 'BlankNode' | 'Literal' | 'Variable' | 'DefaultGraph'` gr Laurens On Wed, Sep 20, 2017 at 11:03 AM, Ruben Taelman <ruben.taelman@ugent.be> wrote: > Dear all, > > Some people (including myself) prefer using typed Javascript, using > TypeScript for instance. > > As I was not able to find any type definitions for the RDFJS interfaces, > I’ve implemented these myself here: > https://github.com/rubensworks/DefinitelyTyped/commit/ > 44292d468be8893f589a1ee4a76dd8d50b588ce3 > > Before I make a PR with these types to the DefinitelyTyped repo, > so that these types would become available as `@types/rdf-js`, > I first want to make sure everyone here agrees with this implementation. > > The JSDoc has been taken directly from the spec. > > Any feedback or comments are welcome! > > Kind regards, > Ruben Taelman > -- VU University Amsterdam Faculty of Exact Sciences Department of Computer Science De Boelelaan 1081 A 1081 HV Amsterdam The Netherlands www.laurensrietveld.nl laurens.rietveld@vu.nl Visiting address: De Boelelaan 1081 Science Building Room T312
Received on Wednesday, 20 September 2017 09:12:38 UTC