RE: Need review of PR-1260: test for assertion 13.4

I started working on the fix for IE and realized there were two errors in the test case:

1) Test passes an invalid pointerId.  This causes a different exception (because INVALID_POINTERID is undefined).
2) Test uses assert_unreachable which should be assert_unreached

I've submitted a pull request to fix these [1].  

Scott, can you take a look and validate my fix? If it looks good, we should just go ahead and merge this.

Thanks!

-Jacob

[1] https://github.com/w3c/web-platform-tests/pull/1270 

-----Original Message-----
From: Jacob Rossi [mailto:Jacob.Rossi@microsoft.com] 
Sent: Wednesday, October 1, 2014 5:44 PM
To: Arthur Barstow; public-pointer-events@w3.org
Subject: RE: Need review of PR-1260: test for assertion 13.4

I reviewed this and it looks good to me. Merged: 
https://github.com/w3c/web-platform-tests/commit/f5e341e6847a2542dae0feb85d45e525b9f4ddfd 

IE11 fails this currently, but we're tracking this bug.

-Jacob

-----Original Message-----
From: Arthur Barstow [mailto:art.barstow@gmail.com] 
Sent: Wednesday, September 24, 2014 11:00 AM
To: public-pointer-events@w3.org
Subject: Need review of PR-1260: test for assertion 13.4

Hi All,

Scott submitted [PR-1260] to cover test assertion 13.4 (and to address part of Action-124). Thanks Scott!

Would someone please commit to review this test?

-Thanks, ArtB

[PR-1260] https://github.com/w3c/web-platform-tests/pull/1260


-------- Original Message --------
Subject: 	[web-platform-tests] setPointerCapture() on disconnected node 
throws InvalidStateError (#1260)
Date: 	Wed, 24 Sep 2014 05:45:00 -0700
From: 	Scott González <notifications@github.com>
Reply-To: 	w3c/web-platform-tests 
<reply+i-43760303-2dd50d571046e00fee66001d5ff02fb7e9f15488-662425@reply.github.c> 

To: 	w3c/web-platform-tests <web-platform-tests@noreply.github.com>



TA 13.4
Action 124

------------------------------------------------------------------------


        You can merge this Pull Request by running

   git pull https://github.com/scottgonzalez/web-platform-tests setpointercapture-disconnected

Or view, comment on, or merge it at:

https://github.com/w3c/web-platform-tests/pull/1260


        Commit Summary

  * setPointerCapture() on disconnected node throws InvalidStateError


        File Changes

  * *A* pointerevents/pointerevent_setpointercapture_disconnected.html
    <https://github.com/w3c/web-platform-tests/pull/1260/files#diff-0> (49)


        Patch Links:

  * https://github.com/w3c/web-platform-tests/pull/1260.patch
  * https://github.com/w3c/web-platform-tests/pull/1260.diff

-
Reply to this email directly or view it on GitHub <https://github.com/w3c/web-platform-tests/pull/1260>.

Received on Friday, 3 October 2014 18:40:53 UTC