- From: Rick Byers <rbyers@google.com>
- Date: Tue, 7 Jan 2014 10:56:09 -0500
- To: Jacob Rossi <Jacob.Rossi@microsoft.com>
- Cc: "public-pointer-events@w3.org" <public-pointer-events@w3.org>
- Message-ID: <CAFUtAY-LeNBP+iV_EN6ECar9xu_cbi3sLHdk2H8tCOo=AWN96Q@mail.gmail.com>
Sorry for the delay. I reviewed most of these cases back in November, but apparently never sent my summary notes. Again there's a ton of copy and paste between the different test files here without any abstraction, making it unnecessarily tedious to review and maintain. I'm sure I'm missing more problems because the one or two essential properties of a test are burried inside ~150 lines of near-duplicated logic. At a minimum I'd suggest all JavaScript and most CSS be confined to common files which are included from most tests (since they're mostly slight variations on the same theme). That said, except for a handful of bugs, the most basic touch-action scenarios are covered by the tests. There are still a lot of gaps though (which won't be practical to fill I think until the test architecture has been simplified), eg: - any case with 'touch-action: pan-x pan-y' - a couple cases that verify the intersection of touch-action properties. eg. pan-x and pan-y combine to be equivalent to "none", 'pan-x pan-y' and 'pan-y' combine to be equivalent to 'pan-y', etc. - any cases around touch-action and SVG elements (since SVG is explicitly called out in the spec) - changing touch-action on pointerdown has no effect until the next touch - inline elements are ignored for touch-action hit testing purposes (i.e. touching an inline that overflows it's block will use the touch-action from the element underneath the inline, not that of the ancestor block). - touch-action doesn't influence mouse / keyboard panning - parsing verification, eg. - touch-action: pan-x pan-y and pan-y pan-x are the same - "pan-x none" is illegal - "auto none" is illegal - auto, none, etc. round trip through the CSS OM as expected Rick On Tue, Nov 19, 2013 at 7:49 PM, Jacob Rossi <Jacob.Rossi@microsoft.com>wrote: > Following up on my action from today's meeting, I've updated the test > assertions wiki [3] to reflect the new submissions we've made below. > > -Jacob > > [3] > http://www.w3.org/wiki/PointerEvents/TestAssertions#Test_Assertions_for_touch-action_CSS_property > > -----Original Message----- > From: Jacob Rossi [mailto:Jacob.Rossi@microsoft.com] > Sent: Monday, November 18, 2013 9:59 PM > To: public-pointer-events@w3.org > Subject: [pointerevents-tests] touch-action test cases from Microsoft > > Hi folks, > > I've updated Microsoft's current pull request [1] with additional test > cases from our team that cover various touch-action requirements, including > testing aspects of the processing model. We appreciate your feedback. > > We're in the process of addressing the feedback from the first set of > tests and will update our submission once that is complete. [2] > > Thanks, > > Jacob > > [1] https://github.com/w3c/web-platform-tests/pull/324 > [2] > http://lists.w3.org/Archives/Public/public-pointer-events/2013OctDec/0043.html > > >
Received on Tuesday, 7 January 2014 15:56:56 UTC