- From: Markus Lanthaler via GitHub <sysbot+gh@w3.org>
- Date: Wed, 14 Mar 2018 07:31:14 +0000
- To: public-hydra-logs@w3.org
Review status: 0 of 2 files reviewed at latest revision, 13 unresolved discussions.
---
*[spec/latest/core/core.jsonld, line 392 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YKuuV5yMe3lgR1S0B:-L7YKuuWTsusqhK9mRa_:b-8x7dej) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/core.jsonld#L392)):*
> rdf:Property
This should be a `hydra:TemplatedLink`
---
*[spec/latest/core/index.html, line 861 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLMfl4fYHGCs2DJhx:-L7YLMfl4fYHGCs2DJhy:bwbt4k4) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L861)):*
> ```HTML
>
> <section>
> <h3>Collection members' link template</h3>
> ```
member's -> member
---
*[spec/latest/core/index.html, line 863 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLTBXFw5369YKoLAr:-L7YLJ0HRkT6GlneIOwQ:bt2771x) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L863)):*
> ```HTML
> <h3>Collection members' link template</h3>
>
> <p>In some circumstances it is useful to give a direct access to collection's
> ```
to collection's -> to a collection's
---
*[spec/latest/core/index.html, line 864 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLXQTvhPYEpQglR1Y:-L7YLXQTvhPYEpQglR1Z:bbpsu0i) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L864)):*
> ```HTML
>
> <p>In some circumstances it is useful to give a direct access to collection's
> members by providing an instruction on how to construct an URL by the client.
> ```
by the client -> to the client
---
*[spec/latest/core/index.html, line 865 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLfbiJHwlk34_rF_l:-L7YLfbiJHwlk34_rF_m:bwdo8cd) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L865)):*
> This URL then can be used either to obtain member's details or to update it, i.e. as a result of some batch processing.
--> This URL may then be used to either retrieve a member's details or to update it.
I would drop the "i.e. as a result of some batch processing" as I find it confusing and it doesn't add much.
---
*[spec/latest/core/index.html, line 867 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YMFhzYVr_XMjD6zof:-L7YMFi-ah2JMu-_PT63:brah2o6) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L867)):*
> Hydra introduces <i>memberTemplate</i> link that directly binds an owning
Hydra provides the <i>memberTemplate</i> property to describe the URL structure of collection members with an <i>IriTemplate</i>.
---
*[spec/latest/core/index.html, line 871 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YMvmXf0Bi5whYCVeo:-L7YMvmXf0Bi5whYCVep:b-u7wgt6) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L871)):*
> ```HTML
>
> <pre class="example nohighlight" data-transform="updateExample"
> title="Collection with a direct access to it's members via an IRI template member link.">
> ```
it's --> its
I would also drop the "member link." at the end (including the dot as elsewhere).
---
*[spec/latest/core/index.html, line 879 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YNjo1Wn0-1a0afDi6:-L7YNjo1Wn0-1a0afDi7:b-7m1exh) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L879)):*
> ```HTML
> "totalItems": "329",
> "member": [
> ####... a subset of the members of the Collection ...####
> ```
If it is a subset it needs to be a partial collection. I'd just update the comment and keep it a Collection
---
*[spec/latest/core/index.html, line 883 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YNxBQdWZpWNH-xGRX:-L7YNxBQdWZpWNH-xGRY:b-njlrr3) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L883)):*
> `http://api.example/com/users{?userName}`
Please use `http://api.example.com/users/{userName}` to be consistent with the other examples
---
*[spec/latest/core/index.html, line 888 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YO8UaSjUFfQkbEvac:-L7YO8UaSjUFfQkbEvad:b4ng7cq) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L888)):*
> ```HTML
> "@type": "IriTemplateMapping",
> "variable": "userName",
> "property": "http://vocab.example.com/userName",
> ```
`http://vocab.example.com/userName` --> `http://api.example.com/vocab#userName`
---
*[spec/latest/core/index.html, line 894 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOM4ImT4F_lcpiqA_:-L7YOM4ImT4F_lcpiqAa:b-wre14y) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L894)):*
> ```HTML
> "@type": "Operation",
> "method": "PUT",
> "expects": "http://vocab.example.com/User"
> ```
--> `http://api.example.com/vocab#User`
---
*[spec/latest/core/index.html, line 896 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOQB5BzH0xEbCF5Aq:-L7YOQB5BzH0xEbCF5Ar:b-8vuuyv) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L896)):*
> ```HTML
> "expects": "http://vocab.example.com/User"
> }
> }
> ```
Please indent using spaces as the rest of the document instead of tabs
---
*[spec/latest/core/index.html, line 904 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOkX_fJPar7Zs9Ldm:-L7YOkX_fJPar7Zs9Ldn:b-d514go) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L904)):*
> the API exposes a direct access to the collection of
> users by providing an IRI template that expects a user name property making
> it a fully functional link. There is also an operation declared that enables
> client to update a given user with an HTTP <i>PUT</i> method.
the API describes how to directly access a member of the <code>/users</code> collection through an IRI Template requiring the user name. There is also an operation that tells a client that it can use HTTP PUT on those resources.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/158)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by lanthaler
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/158#issuecomment-372929091 using your GitHub account
Received on Wednesday, 14 March 2018 07:31:19 UTC