- From: Karol Szczepański via GitHub <sysbot+gh@w3.org>
- Date: Wed, 14 Mar 2018 20:02:29 +0000
- To: public-hydra-logs@w3.org
Review status: 0 of 2 files reviewed at latest revision, 13 unresolved discussions.
---
*[spec/latest/core/core.jsonld, line 392 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YKuuV5yMe3lgR1S0B:-L7a5ZUeeekiEuG5EhxI:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/core.jsonld#L392)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
> rdf:Property
This should be a `hydra:TemplatedLink`
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 861 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLMfl4fYHGCs2DJhx:-L7a3uV-bDI6CGjEiCO2:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L861)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
member's -> member
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 863 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLTBXFw5369YKoLAr:-L7a3ydatwddCXpUe0lv:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L863)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
to collection's -> to a collection's
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 864 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLXQTvhPYEpQglR1Y:-L7a4-k4SF_5OukMYTOF:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L864)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
by the client -> to the client
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 865 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YLfbiJHwlk34_rF_l:-L7a46SKXuesfqqzHf9f:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L865)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
> This URL then can be used either to obtain member's details or to update it, i.e. as a result of some batch processing.
--> This URL may then be used to either retrieve a member's details or to update it.
I would drop the "i.e. as a result of some batch processing" as I find it confusing and it doesn't add much.
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 867 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YMFhzYVr_XMjD6zof:-L7a4EP_y4xmGsBVnsPa:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L867)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
> Hydra introduces <i>memberTemplate</i> link that directly binds an owning
Hydra provides the <i>memberTemplate</i> property to describe the URL structure of collection members with an <i>IriTemplate</i>.
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 871 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YMvmXf0Bi5whYCVeo:-L7a4MuPDdFs94v10caV:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L871)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
it's --> its
I would also drop the "member link." at the end (including the dot as elsewhere).
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 879 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YNjo1Wn0-1a0afDi6:-L7a4TYs79v4Veoic0yd:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L879)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
If it is a subset it needs to be a partial collection. I'd just update the comment and keep it a Collection
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 883 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YNxBQdWZpWNH-xGRX:-L7a4Xmr2plsPeA4ExaM:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L883)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
> `http://api.example/com/users{?userName}`
Please use `http://api.example.com/users/{userName}` to be consistent with the other examples
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 888 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YO8UaSjUFfQkbEvac:-L7a4cyP8ik1NsvHIh73:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L888)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
`http://vocab.example.com/userName` --> `http://api.example.com/vocab#userName`
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 894 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOM4ImT4F_lcpiqA_:-L7a4g2MHm6-71hNdw96:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L894)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
--> `http://api.example.com/vocab#User`
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 896 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOQB5BzH0xEbCF5Aq:-L7a5-bk1Twfv_5BKQ-L:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L896)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
Please indent using spaces as the rest of the document instead of tabs
</blockquote></details>
Done.
---
*[spec/latest/core/index.html, line 904 at r2](https://reviewable.io:443/reviews/hydracg/specifications/158#-L7YOkX_fJPar7Zs9Ldm:-L7a5LkzxHkNxvbnMnM4:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/96a8db38dce72df69512cc7ea38f42b71cd256f5/spec/latest/core/index.html#L904)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
> the API exposes a direct access to the collection of
> users by providing an IRI template that expects a user name property making
> it a fully functional link. There is also an operation declared that enables
> client to update a given user with an HTTP <i>PUT</i> method.
the API describes how to directly access a member of the <code>/users</code> collection through an IRI Template requiring the user name. There is also an operation that tells a client that it can use HTTP PUT on those resources.
</blockquote></details>
Done.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/158)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by alien-mcl
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/158#issuecomment-373155935 using your GitHub account
Received on Wednesday, 14 March 2018 20:02:33 UTC