- From: Markus Lanthaler via GitHub <sysbot+gh@w3.org>
- Date: Tue, 13 Mar 2018 07:36:43 +0000
- To: public-hydra-logs@w3.org
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.
---
*[spec/latest/core/core.jsonld, line 314 at r1](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TFzllEv7mowjAT0a_-r1-314:-L7TH0RKp9wG-3jCmU4F:b-txmw0k) ([raw file](https://github.com/hydracg/specifications/blob/fa9f921099c077c5ecebaf84c80e8d0a6c77629f/spec/latest/core/core.jsonld#L314)):*
<details><summary><i>Previously, alien-mcl (Karol Szczepański) wrote…</i></summary><blockquote>
Well, #41 is marked as resolved with `hydra:manages` as one of the solutions. While I think it indeed solves some problems, I've got personal issues with `hydra:collection` as I don't see any reason for making a special distinction between ordinary link and collection link (as this is how I understand `hydra:collection`)
</blockquote></details>
Yep, there was a call for consensus with no objections
---
*[spec/latest/core/core.jsonld, line 37 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TGDtVei7XRPeTC5KR:-L7TGDtVei7XRPeTC5KS:b-6lmo23) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L37)):*
> ```JSONLD
> "Collection": "hydra:Collection",
> "member": { "@id": "hydra:member", "@type": "@id" },
> "manages": { "@id": "hydra:manages", "@type": "@id" },
> ```
We can simplify this to simply `"hydra:manages"`
---
*[spec/latest/core/core.jsonld, line 308 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TGe1RfkrVqKIqdZpa:-L7TGe1RfkrVqKIqdZpb:byb62no) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L308)):*
> Allows to link multiple collections to an owning resource.
Please change this to something like "Collections somehow related to this resource."
---
*[spec/latest/core/core.jsonld, line 322 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TH8Ol6lKqeotzdVOL:-L7TH8Ol6lKqeotzdVOM:be851uv) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L322)):*
> "Provides details on on the resource being a subject in relation described by the collection."
As we might re-use this elsewhere at some point I'd suggest to change it to simply "The subject."
---
*[spec/latest/core/core.jsonld, line 324 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7THQA_0Gtj93jo2abC:-L7THQA_0Gtj93jo2abD:bgigmx5) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L324)):*
> ```JSONLD
> "comment": "Provides details on on the resource being a subject in relation described by the collection.",
> "vs:term_status": "testing"
> },
> ```
Looks like you forgot to add `hydra:object`
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/157)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by lanthaler
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/157#issuecomment-372573406 using your GitHub account
Received on Tuesday, 13 March 2018 07:36:51 UTC