- From: Karol Szczepański via GitHub <sysbot+gh@w3.org>
- Date: Tue, 13 Mar 2018 19:32:18 +0000
- To: public-hydra-logs@w3.org
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions. --- *[spec/latest/core/core.jsonld, line 37 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TGDtVei7XRPeTC5KR:-L7Vn43qbxGa_L33cSgs:bqxgtuc) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L37)):* <details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote> We can simplify this to simply `"hydra:manages"` </blockquote></details> Are you sure? Indeed when the value of this relation will be a JSON-object, expansion will work. But I've noticed that string literals are not correctly interpreted as resource IRIs. I know, that in most cases there will be an object here, but still, corner case may get broken. --- *[spec/latest/core/core.jsonld, line 308 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TGe1RfkrVqKIqdZpa:-L7VoSJGYgFocIF3uKGA:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L308)):* <details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote> > Allows to link multiple collections to an owning resource. Please change this to something like "Collections somehow related to this resource." </blockquote></details> Done. --- *[spec/latest/core/core.jsonld, line 322 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7TH8Ol6lKqeotzdVOL:-L7VodIG3E3DifO4dKVc:b-896fix) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L322)):* <details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote> > "Provides details on on the resource being a subject in relation described by the collection." As we might re-use this elsewhere at some point I'd suggest to change it to simply "The subject." </blockquote></details> Done. --- *[spec/latest/core/core.jsonld, line 324 at r2](https://reviewable.io:443/reviews/hydracg/specifications/157#-L7THQA_0Gtj93jo2abC:-L7VohfSGVlfuLSII_vT:be4gbx1) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L324)):* <details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote> Looks like you forgot to add `hydra:object` </blockquote></details> Hmm. Honestly - I though it was enlisted mistakenly. I acknowledged `hydra:manages` block is to re-instantiate the relation between the resource owning a given collection (i.e. resource being on the left of the `hydra:collection` predicate) and the resources provided by the collection. Having an explicit `hydra:object` here could prove difficult for interpretation on what actually that owning resource is doing here in case `hydra:object` does not point to that owning resource. Also having all subject-property-object components, why having them repeated in the Hydra vocab instead of using rdf reification ones? I've added it, as the #41 states it as a solution, but I'm not convinced we need that. --- *Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/157)* <!-- Sent from Reviewable.io --> -- GitHub Notification of comment by alien-mcl Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/157#issuecomment-372790637 using your GitHub account
Received on Tuesday, 13 March 2018 19:32:19 UTC