- From: Markus Lanthaler via GitHub <sysbot+gh@w3.org>
- Date: Fri, 30 Mar 2018 12:01:36 +0000
- To: public-hydra-logs@w3.org
Review status: all files reviewed at latest revision, 1 unresolved discussion.
---
*[spec/latest/core/core.jsonld, line 37 at r2](https://beta.reviewable.io/reviews/hydracg/specifications/157#-L7TGDtVei7XRPeTC5KR:-L8qlSwwCNNVDATEQNPy:b-w15flx) ([raw file](https://github.com/hydracg/specifications/blob/fec61202e499babbb3163063b674fabb2df67558/spec/latest/core/core.jsonld#L37)):*
<details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote>
Oh, the object will be the "manages block", right? Yes, it probably makes little sense to have type coercion here
</blockquote></details>
Yes, the it will be the "manages block"
---
*[spec/latest/core/core.jsonld, line 39 at r3](https://beta.reviewable.io/reviews/hydracg/specifications/157#-L8qlYYe3wtA7_nxipL0:-L8qlYYe3wtA7_nxipL1:b-yinqhd) ([raw file](https://github.com/hydracg/specifications/blob/697bd7aea8decf68e0ba45fb18942b0e87cbae29/spec/latest/core/core.jsonld#L39)):*
> ```JSONLD
> "manages": { "@id": "hydra:manages", "@type": "@id" },
> "subject": { "@id": "hydra:subject", "@type": "@id" },
> "object": { "@id": "hydra:subject", "@type": "@id" },
> ```
`hydra:subject`
This needs to be `hydra:object`. Could you please type-coerce both to `@vocab` (like `property`)
---
*[spec/latest/core/core.jsonld, line 172 at r3](https://beta.reviewable.io/reviews/hydracg/specifications/157#-L8qm--V-2_2HLY7Akhy:-L8qm--V-2_2HLY7Akhz:bkhqybb) ([raw file](https://github.com/hydracg/specifications/blob/697bd7aea8decf68e0ba45fb18942b0e87cbae29/spec/latest/core/core.jsonld#L172)):*
> ```JSONLD
> "@type": "rdf:Property",
> "label": "property",
> "comment": "A property, either supported by a class or described by a collection",
> ```
This just makes the documentation more confusing. I'd suggest to revert this change.
---
*Comments from [Reviewable](https://beta.reviewable.io/reviews/hydracg/specifications/157)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by lanthaler
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/157#issuecomment-377510314 using your GitHub account
Received on Friday, 30 March 2018 12:01:54 UTC