Re: [Specifications] Actions with explicit target

Review status: 0 of 8 files reviewed at latest revision, 6 unresolved discussions.

---

*[drafts/use-cases/1.entry-point.md, line 94 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L6qKMefMi47gmHpdvUv:-L6qKMegCW1PIpWll9-Z:b-x1upf9) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/1.entry-point.md#L94)):*
> ```Markdown
>           "method": "POST",
>           "expects": "schema:Place",
>           "target": "/api/venues"
> ```

Isn't it weird to have this id repeated here where it's the subject of `action`?

---

*[drafts/use-cases/5.1.creating-event-with-put.md, line 67 at r1](https://reviewable.io:443/reviews/hydracg/specifications/154#-L2FGn5gasTIWY81_mpI:-L6qLiNpKllGMuILNNvb:b-pyjk8f) ([raw file](https://github.com/hydracg/specifications/blob/aa28c5c639dde02c9aacfaf7f5d7121b0d7caa3b/drafts/use-cases/5.1.creating-event-with-put.md#L67)):*
<details><summary><i>Previously, elf-pavlik (elf Pavlik) wrote…</i></summary><blockquote>

I don't think any of current use cases exemplifies requirement for such 'direct lookups'. Maybe until someone proposes (via PR) a clear use case for such 'direct lookups', we will not try to deal with that requirement?
</blockquote></details>

Meaning we actually want to remove `memberTemplate` completely?

---

*[drafts/use-cases/5.1.creating-event-with-put.md, line 28 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L6qL2xZ0izObS8VgEvs:-L6qL2xZ0izObS8VgEvt:b-iql7q3) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/5.1.creating-event-with-put.md#L28)):*
> ```Markdown
> var client = new HydraClient();
> var operation = client.get('http://example.com/events');
>     .getOperationsOfType('http://schema.org/AddAction')
> ```

So this should be called `getActionsOfType` and the operation takes from `action.operation`?

---

*[drafts/use-cases/5.1.creating-event-with-put.md, line 33 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L6qLS1rPACGmw8J2dm2:-L6qLS1rPACGmw8J2dm3:bp9qh5l) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/5.1.creating-event-with-put.md#L33)):*
> ```Markdown
> if (operation) {
>   var templateVariables = {
>       'schema:name' : 'meeting with-will'
> ```

So the expansion uses the variable name or the property?
Any why did is change from array to a string?

---

*[drafts/use-cases/7.searching-events.md, line 19 at r1](https://reviewable.io:443/reviews/hydracg/specifications/154#-L2FHzTqp1okBeqnrpBL:-L6qLtGZQI-zR8DXd256:b-q4fgx6) ([raw file](https://github.com/hydracg/specifications/blob/aa28c5c639dde02c9aacfaf7f5d7121b0d7caa3b/drafts/use-cases/7.searching-events.md#L19)):*
<details><summary><i>Previously, alien-mcl (Karol Szczepański) wrote…</i></summary><blockquote>

I'd introduce separate method, i.e. `getActionOfType` - my understanding is _action_ is somehow an _accusative_ (if I can say it that way) for the operation as it changes position of the target within a _sentence_ (if you know what I mean). 
</blockquote></details>

Ah yes, what I commented above. Would see it more like

```
var operation = client.get(string).getActionOfType(string).operation
```

---


*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/154)*
<!-- Sent from Reviewable.io -->


-- 
GitHub Notification of comment by tpluscode
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/154#issuecomment-370419784 using your GitHub account

Received on Monday, 5 March 2018 13:33:01 UTC