- From: elf Pavlik via GitHub <sysbot+gh@w3.org>
- Date: Sun, 18 Mar 2018 22:00:29 +0000
- To: public-hydra-logs@w3.org
Review status: all files reviewed at latest revision, 8 unresolved discussions.
---
*[drafts/use-cases/0.intro.md, line 61 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L7phzWK_cLAGjwnFap_:-L7v5gkz37ZotRqtj6wI:b-p6twst) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/0.intro.md#L61)):*
<details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote>
Also, I notice that there is a schema:target too. This can be confusing
</blockquote></details>
In latest version of this PR `hydra:operation` references `hydra:Operation` from `schema:Action`, not any more from `hydra:Resource`
---
*[drafts/use-cases/5.1.creating-event-with-put.md, line 33 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L6qLS1rPACGmw8J2dm2:-L7v6PGF-ZJKMRSHaMeP:b-xz75dl) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/5.1.creating-event-with-put.md#L33)):*
<details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote>
Well, both can change :slightly_smiling_face:. But neither is out-of-bounds so there is not issue with allowing either. After all this information comes from the template mappings.
Still, I don't understand why two value concatenated into one string. What if one was to have spaces? :) And full URL should be used (or possibly proper JSON-LD)
``` json
{
"http://schema.org/name": [
{ "@value": "meeting" },[
{ "@value": "with will" }
]
}
```
</blockquote></details>
If server uses some value to compose IRI it probably has to URL encode that value
---
*[drafts/use-cases/7.searching-events.md, line 72 at r3](https://reviewable.io:443/reviews/hydracg/specifications/154#-L7pnYSMDeJ6U5y0ECUB:-L7v6kgxbC8OG64KZ79h:bycldza) ([raw file](https://github.com/hydracg/specifications/blob/fa23516a0e71bf50633726d839217103245d7544/drafts/use-cases/7.searching-events.md#L72)):*
<details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote>
Yes! Kill it, kill it :fire:
Why not just remove `search` and `memberTemplate` from the vocabulary with this very PR... (if it hasn't been done yet)
</blockquote></details>
to remove `hydra:search` we have to share such proposal with a mailing list, i could follow up with another PR just for that. As for `hydra:memberTemplate` - if we need it for some 'random access' type of feature we probably should add a Use Case for it first.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/154)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by elf-pavlik
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/154#issuecomment-374054385 using your GitHub account
Received on Sunday, 18 March 2018 22:00:31 UTC