W3C home > Mailing lists > Public > public-html-media@w3.org > September 2016

Re: outstanding MSE test suite pull requests, creation of test results and draft Proposed Recommendation

From: Matt Wolenetz <wolenetz@google.com>
Date: Tue, 6 Sep 2016 21:58:22 -0700
Message-ID: <CAADho6MTcYPERdw2h+1dotZ10xp4M=t83MxTnS6aWGFPHf9EMA@mail.gmail.com>
To: Paul Cotton <Paul.Cotton@microsoft.com>
Cc: Mark Watson <watsonm@netflix.com>, "Jerry Smith (WPT)" <jdsmith@microsoft.com>, "Philippe Le Hegaret (plh@w3.org)" <plh@w3.org>, "public-html-media@w3.org" <public-html-media@w3.org>
After some focused work today, only 2 MSE test suite PRs (both mine, in
need of review by co-editors) and 1 MSE spec issue (the non-blocking
registry rehoming issue assigned to @plehegar) currently remain open for v1.

Details:

   - Landed my https://github.com/w3c/web-platform-tests/pull/3613 after
   review from @jdsmith3000
   - Updated and landed my https://github.com/w3c/web-
   platform-tests/pull/3635 after review from @jdsmith3000
   - Updated and landed my https://github.com/w3c/web-
   platform-tests/pull/3082 after incorporating feedback from @tidoust
      - *TODO: Update the related crbug since this may not be a compliance
      issue after all*
      - *TODO: Update the Chrome layout test, too*
   - Reviewed and landed @plehegar's https://github.com/w3c/web-
   platform-tests/pull/3207
   - Reviewed, updated and landed @plehegar's https://github.com/w3c/web-
   platform-tests/pull/3206
      - *In-progress*: Prepared https://codereview.chromium.org/2315113002/ to
      fix Chrome crbug 623781 <http://crbug/623781>
      - *In-progress*: Fix upstream addSourceBuffer(null) case to expect
      NotSupportedError instead of TypeError
         - Prepped https://github.com/w3c/web-platform-tests/pull/3653 to
         fix this. *In review currently*
      - Reviewed, updated and landed @plehegar's https://github.com/w3c/web-
   platform-tests/pull/3205
      - crbug 607372 <http://crbug/607372> tracks Chromium compliance
      failure exposed by this test.
   - Reviewed, assessed new coverage contained within, and replaced
   @tidoust's https://github.com/w3c/web-platform-tests/pull/3232 with:
      - Prepped https://github.com/w3c/web-platform-tests/pull/3655 to
      include that coverage plus a bit more. *In review currently*
      - crbug 639144 <http://crbug/639144> tracks fixing one failing new
      subtest
   - Reviewed low-pri (out of V1 scope, VPQ-related) and replaced
   @tidoust's https://github.com/w3c/web-platform-tests/pull/3231 with:
      - Prepped and landed https://github.com/w3c/web-
      platform-tests/pull/3656
   - As of Tuesday EOD:
      - Two of my PR's are pending review:
         - https://github.com/w3c/web-platform-tests/pull/3653 *(@jdsmith3000
         please review ASAP)*
         - https://github.com/w3c/web-platform-tests/pull/3655 *(@jdsmith3000
         please review ASAP. @jyavenard and @tidoust may also want to
chime in.)*
      - The other 3 remaining media-source w-p-t open PRs (
      https://github.com/w3c/web-platform-tests/pulls?utf8=%E2%
      9C%93&q=is%3Apr%20is%3Aopen%20label%3Amedia-source
      <https://github.com/w3c/web-platform-tests/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20label%3Amedia-source>)
      are not blocking MSE v1:
         - https://github.com/w3c/web-platform-tests/pull/1816 (cross-cutting
         incomplete test infra change)
         - https://github.com/w3c/web-platform-tests/pull/1405 (deferred to
         VNext, isTypeSupported updates), likewise increased coverage of
         isTypeSupported as mentioned in https://github.com/w3c/web-
         platform-tests/issues/1386 (the only currently open w-p-t MSE
         issue)
         - https://github.com/w3c/web-platform-tests/pull/954 (deferred to
         VNext, appendStream related)
      - I triaged the only untriaged MSE issue to VNext (
      https://github.com/w3c/media-source/issues/156
      <https://github.com/w3c/media-source/issues/156>)
      - The only MSE v1 spec issue remaining, is non-blocking (editorial),
      and is the registry rehoming/update issue:
      https://github.com/w3c/media-source/issues/74
      <https://github.com/w3c/media-source/issues/74>

-Matt

On Tue, Sep 6, 2016 at 9:01 AM, Paul Cotton <Paul.Cotton@microsoft.com>
wrote:

> >2 of my PRs are currently pending co-editor review. 5 pending PRs are
> still awaiting my full review.
>
>
>
> We MUST get all the outstanding MSE test suite pull requests processed
> ASAP so that we can move on to using the resulting test suite.  We are
> running out of chartered time to do this work!
>
>
>
> For the older six outstanding PRs created by Philippe or Francois we are
> going to consider them okay unless someone specifically pushes back before
> noon PDT on Wed Sep 7.  After that Philippe or Francois should feel free to
> merge their own PRs:
> https://github.com/w3c/web-platform-tests/pulls?q=is%3Apr
> +is%3Aopen+label%3Amedia-source
>
>
>
> For Matt’s new PRs the same approach applies.  Others have until noon PDT
> on Wed Sep 7 to review them and after that Matt should feel free to apply
> his own PRs.
>
>
>
> >ACTION: plh to generate the new MSE draft PR, pointing to the testing
> results
>
>
>
> Hopefully this will permit us to conclude work on the MSE test suite later
> on Wed and for Philippe to create new test results on Thu and to create a
> MSE draft Proposed Recommendation before the end of this week.
>
>
>
> /paulc
>
>
>
> *From:* Matt Wolenetz [mailto:wolenetz@google.com]
> *Sent:* Friday, September 2, 2016 7:24 PM
> *To:* Paul Cotton <Paul.Cotton@microsoft.com>
> *Cc:* public-html-media@w3.org
> *Subject:* Re: HME WG meeting minutes, Tue Aug 30
>
>
>
> I've made some progress, not as much as I had hoped. 2 of my PRs are
> currently pending co-editor review. 5 pending PRs are still awaiting my
> full review.
>
>
>
> Detail:
>
> ·        Prepped PR to cover 4 gaps from #823 :
> https://github.com/w3c/web-platform-tests/pull/3635
>
> o   *Awaiting @jdsmith3000's review to land it*
>
> o   crbug 623781 <http://crbug/623781> tracks fixing the Chrome
> compliance issue behind at least the failure of 2 subtests (TypeError) in
> mediasource-addsourcebuffer.html
>
> o   Filed crbug 643788 <http://crbug/643788> to fix debug build assertion
> in w-p-t mediasource-removesourcebuffers.html and landed my fix for it
> <https://codereview.chromium.org/2305023002>
>
> ·        Reviewed and closed ancient https://github.com/
> w3c/web-platform-tests/pull/939
>
> o   Found only 1 trivial test coverage gap, prepped and merged trivial PR
> to close that gap: https://github.com/w3c/web-platform-tests/pull/3636
>
> ·        Deferred to VNext ancient appendStream coverage test PR
> https://github.com/w3c/web-platform-tests/pull/954
>
> ·        Deferred to VNext more strict isTypeSupported() coverage test PR
> https://github.com/w3c/web-platform-tests/pull/1405
>
> ·        Commented on mechanical PR https://github.com/w3c/web-
> platform-tests/pull/1816 (doesn't block MSE v1 PR, it's a cross-cutting
> infra PR)
>
> ·        In-progress: Fixing https://github.com/w3c/
> web-platform-tests/pull/3082
>
> o   Filed, and in-progress fixing (short-term Chrome MSE piece of) crbug
> 643846 <http://crbug/643846>
>
> ·        TODO 5 more pending PRs...
>
>
>
> On Tue, Aug 30, 2016 at 6:42 PM, Matt Wolenetz <wolenetz@google.com>
> wrote:
>
>
>
> On Tue, Aug 30, 2016 at 11:20 AM, Paul Cotton <Paul.Cotton@microsoft.com>
> wrote:
>
> *MSE test suite results*
>
> <*plh*> Paul: still some outstanding pull requests
>
> https://lists.w3.org/Archives/Public/public-html-media/2016Aug/0102.html
> is Matt's most recent update
>
> <*plh*> Matt: going through them...
>
> Outstanding PRs: https://github.com/w3c/web-platform-tests/pulls?q=is%3Apr
> +is%3Aopen+label%3Amedia-source
>
> <*plh*> ... resolving the merge conflict
>
> <*plh*> ... I'll send out an update later today
>
>
> I've worked through about 5 of the 15 pending PRs today, and will continue
> tomorrow. Current status:
>
> ·
>
> ·        Merged @tidoust's https://github.com/w3c/web-platform-tests/pull/
> 3239
>
> ·        Prepped and landed my https://github.com/w3c/web-
> platform-tests/pull/3612
>
> ·        Needed Chromium+W3C license stamp, so this replaces/extends
> @tidoust's https://github.com/w3c/web-platform-tests/pull/3264
>
> ·        Updated and landed my https://github.com/w3c/web-
> platform-tests/pull/3296
>
> ·        Landed @tidoust's https://github.com/w3c/web-platform-tests/pull/
> 3233
>
> ·        Prepped PR to fix the test introduced in #3233 to comply with
> w3c/media-source#154: https://github.com/w3c/web-platform-tests/pull/3613
>
> o   *Awaiting @jdsmith3000's review to land it*
>
> o   crbug 639144 <http://crbug/639144> tracks fixing the Chrome
> compliance issue behind failure of subtest 1/3 in this PR
>
> o   crbug 373039 <http://crbug/373039> is one of a group of bugs tracking
> fixing the Chrome compliance issue behind failure of subtest 3/3 in this PR
>
> ·        Reviewed ancient https://github.com/w3c/web-platform-tests/pull/
> 823
>
> o   Found 4 gaps, but otherwise closed this PR since most of the coverage
> it includes is already covered elsewhere in our current suite
>
> ·        In-progress: put together PR to cover 4 gaps from #823
>
> o   crbug 623781 <http://crbug/623781> tracks fixing the Chrome
> compliance issue behind at least the failure of 2 subtests (TypeError) in
> mediasource-addsourcebuffer.html
>
> o   *In-progress: Investigating Chromium issue with PR I'm building to
> cover the 4 test gaps.*
>
> ·        TODO 10 more pending PRs, followed by call to regenerate reports
> and lists of known user agent bugs tracking test failures.
>
>
>
Received on Wednesday, 7 September 2016 04:59:34 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 7 September 2016 04:59:35 UTC