W3C home > Mailing lists > Public > public-fx@w3.org > October to December 2014

Re: [web-animations] Please, clarify Keyframe.composite default value

From: Aleksei Semenov <a.semenov@unipro.ru>
Date: Thu, 27 Nov 2014 16:13:57 +0600
To: "public-fx@w3.org" <public-fx@w3.org>, "Brian Birtles" <bbirtles@mozilla.com>
Cc: "dom@unipro.ru" <dom@unipro.ru>
Message-ID: <op.xpzapjrhfqy7hv@semenov-pc.unipro.ru>
Hi Brian.

Yes, you have correctly understood the issue.
Thank you for the fix.

Thanks,
Aleksei.

Brian Birtles <bbirtles@mozilla.com> писал(а) в своём письме Thu, 27 Nov  
2014 10:57:31 +0600:

> Hi Aleksei,
>
> On 2014/11/07 20:14, Aleksei Semenov wrote:
>> The default value for 'composite' attribute is specified as null (
>> http://w3c.github.io/web-animations/#dictdef-keyframe )
>> However if keyframe input contains attribute 'composite' with the value
>> null, the procedure for converting an ECMAScript value to an IDL
>> enumeration type <http://www.w3.org/TR/WebIDL/#es-enumeration>[WEBIDL]
>> <http://w3c.github.io/web-animations/#biblio-webidl>
>> will throw TypeError, because null does not belong to CompositeOperation
>> <http://w3c.github.io/web-animations/#compositeoperation> enum.
>
> If I've understood the issue correctly, then I think we should handle  
> null correctly in the procedure for processing keyframe objects. This  
> applies to both 'composite' and 'offset'.
>
> I've made a change to that effect:
>
>   
> https://github.com/w3c/web-animations/commit/957350a0c2bb140a30030d70bf7a9ddc3dda5cca
>
> Please let me know if I've misunderstood the issue.
>
> Best regards,
>
> Brian


-- 
Написано в почтовом клиенте браузера Opera: http://www.opera.com/mail/
Received on Thursday, 27 November 2014 10:14:29 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:49:52 UTC