Re: [masking] Comments on September 13 editor's draft

Hi Alan,

Thank you very much for your review!

On Sep 13, 2013, at 2:51 PM, Alan Stearns <stearns@adobe.com> wrote:

> Section 1
> 
> s/mask forgoing/mask, forgoing/
> s/Clipping path defines/A clipping path defines/
> s/applied on a shape/applied on an element/

Yes, done.

> 
> Section 4
> 
> "These effects all apply after any other CSS effects such as 'border'
> [CSS3BG]. 
> 
> 'CSS effects' is probably too broad - aren't animations 'CSS effects'? I'd
> expect that to come after clipping/masking. You probably want to say
> something like: "These effects all apply after any element drawing
> operations from CSS properties such as 'border'"

I agree. Changed.

> 
> In the user/local coordinate systems definition, do you need to define
> what the units are in the last paragraph?

The unit to CSS pixel definition is not needed. Removed.

> 
> The definition of clipping path should read: "Either a combination of SVG
> graphics elements or a basic shape"

Fixed.

> 
> Section 5
> 
> If there is a mask image failure (empty image, failure to download, etc.)
> is a stacking context still created? Same question for
> mask-box-image-source and clip-path.

Yes, as specified. Even if we do just have one layer for now, we potentially have multiple layers in which case the failing resource is replaced by a masking neutral image.

> 
> The definition of mask-source-type:auto refers to the <mask-image> type.
> It should probably be referring to the <image> type

Yes, fixed.

> 
> s/choosen/chosen/ (2 instances)

Thanks. done.

> 
> The <mask-layer> definition should include some line breaks for readability

Good point! I wrapped the lines.

> 
> s/no affect if/no effect if/

done.

> 
> The last paragraph of 5.11.1 needs an "or the luminance..." clause.

I am unsure what you mean here. The whole section handles the two cases for mask-source: alpha masking and luminance masking. Alpha masking is the second paragraph, luminance are the following paragraphs. The last paragraphs just give a guidance on how to proceed with different kind of image sources like single channel image, three channel images and so on. The last paragraph says that the effect of masking is as if you would multiple the alpha channel of your content with the mask value (luminance or alpha value dependent on the masking operation you chose).

> 
> Section 6
> 
> Should the <mask-image> value be <image> or <mask-source>?

Yes it should! fixed.

> 
> It may be better to duplicate the appropriate descriptions of values and
> other explanations of the mask-box-image-source property that are
> applicable from the mask-source property.

The mask-source property just applies to <mask> elements. It had no relation to any of the other properties.

> 
> Section 7
> 
> The clip-path property description is missing a definition of the <url>
> value.

Added this definition. Thanks.

> 
> Section 8
> 
> It mentions CORS for mask-image, and I assume this should apply to
> mask-box-image-source and clip-path as well.

Yes, that is right. I fixed that.

Again, thanks for your review!

Greetings,
Dirk

>

Received on Friday, 13 September 2013 14:23:41 UTC