Re: [screen-wake-lock] editorial: Improve references to terms from the Page Visibility spec. (#306)

@kenchris @reillyeon I'd appreciate if you could look at this one. Specifically, I'm not 100% sure about this part:

> More generally, these changes should also make it more clear that the
> visibility state checks only apply to the top-level browsing
> context (according to the Page Visibility spec itself). Although we were
> previously checking if a given `Document` was `hidden` even if it did not
> belong to a top-level browsing context, that was simply invalid.

I'm pretty sure that's true, and the only implementation so far (Blink) already checks if the entire `Page` is visible. I think all cases where we'd have e.g. a child browsing context in an iframe that could get hidden while the top-level browsing context did not would fall in the "Handling loss of full document activity" section anyway. Or is there a way to get that sort of visibility change to happen without removing said iframe?

-- 
GitHub Notification of comment by rakuco
Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/pull/306#issuecomment-779230722 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 15 February 2021 13:39:25 UTC