Re: [wake-lock] Canceling using AbortSignal is a bit weird (#171)

> > Contrast this to APIs like fetch() where a request is "done" at some point and can no longer be aborted.
> 
> This isn't really true. Even after the response comes in, the fetch can still be aborted, which cancels the response body.

I'm not sure why you're talking about a request being done if the response body is still being streamed. In contrast a wake lock is never "done" until it is aborted. I think that's the crux of my disagreement. "Abort" feels like something that's exceptional, canceling something before it is complete, while releasing a wake lock is a natural part of its lifecycle.

-- 
GitHub Notification of comment by reillyeon
Please view or discuss this issue at https://github.com/w3c/wake-lock/issues/171#issuecomment-484227228 using your GitHub account

Received on Wednesday, 17 April 2019 19:23:58 UTC