- From: jugglinmike via GitHub <sysbot+gh@w3.org>
- Date: Sun, 26 Aug 2018 22:27:36 +0000
- To: public-device-apis-log@w3.org
(The original discussion about naming has been collapsed, so I'm replying here to avoid confusion.) > Indeed, "MockSensorReading" LGTM. But if we remove the "Set" suffix, the > "GeolocationReadingSet" would be quite similar to GeolocationSesnorReading. If we changed "MockSensorReadingSet" to "MockSensorReading", the corresponding change to "GeolocationReadingSet" would not be "GeolocationReading" but instead "MockGeolocationReading." The latter is very clearly distinct from "GeolocationSensorReading". > How about "MockSensorReadingParamters" or > "MockSensorReadingSetParamters"(maybe "MockSensorReadingSetParams" in short)? > I was thinking it looks too long. I agree that it's a little long. The word "Params" may give an indication that the values are not sets, but as a somewhat vague word, it does this by making the meaning of the term less precise overall. > I finally choose the ”MockSensorReadingSetParams“. A sensor reading contains > timestamps, but user don't need to update the timestamps. I'm not sure that the distinction about the timestamps needs to be reflected in the name. If you think that's helpful, then maybe "Values" is a more meaningful suffix than "SetParams". In other words, "MockSensorReadingValue". -- GitHub Notification of comment by jugglinmike Please view or discuss this issue at https://github.com/w3c/sensors/pull/369#issuecomment-416077354 using your GitHub account
Received on Sunday, 26 August 2018 22:27:37 UTC