Re: [community-group] Dimension type expanded unit types (#245)

I'm not sold on the `vendor` property concept.

If the idea is that `vendor` will hold the name of whatever design tool produced the tokens file, that puts a pretty large burden on design token parsers/transformers to support and maintain mappings from each design tool's units to each target platform's units.

The only other use I can imagine for such a property would be for design tools to optionally denote that the unit is platform specific...

```json
{
    "value": 5,
    "unit": "vh",
    "vendor": "web"
}
```

...but for this approach to be useful, design tools would all need to be consistent in their usage of both `unit` and the optional property. At that point we're back to needing to document units in the spec. While less important, the name of the property should probably also be reconsidered if this is the intended usage.

-- 
GitHub Notification of comment by dev-nicolaos
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/245#issuecomment-2309001955 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Sunday, 25 August 2024 21:32:15 UTC