- From: Louis Chenais via GitHub <sysbot+gh@w3.org>
- Date: Sun, 25 Aug 2024 13:57:40 +0000
- To: public-design-tokens-log@w3.org
Thanks for creating this PR @drwpow 👍 I think splitting the value to an object format is the best solution. I still easy to read while it makes it easier to parse for other languages and tools [as you explained](https://github.com/design-tokens/community-group/pull/244#issuecomment-2298998450). I also think we should create a new PR to introduce the `vendor` property. And finally I agree with @romainmenke about the fact we don't need to add dimensions with a "null unit". Unitless line height can be created as `number` tokens. -- GitHub Notification of comment by ChucKN0risK Please view or discuss this issue at https://github.com/design-tokens/community-group/pull/244#issuecomment-2308858677 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Sunday, 25 August 2024 13:57:41 UTC