W3C home > Mailing lists > Public > public-css-testsuite@w3.org > July 2015

Re: fixed new inline-block alignement test (complete review)

From: Shiozawa, Hajime <hajime.shiozawa@gmail.com>
Date: Sun, 19 Jul 2015 12:00:53 +0900
Message-ID: <CAHSwuKP0aZu8FJ6RzbfM32hbLeyeVVqvnbF_mKt44Jw+DASCPA@mail.gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
Cc: Koji Ishii <kojiishi@gluesoft.co.jp>, Public CSS test suite mailing list <public-css-testsuite@w3.org>
Gérard,

all done!

https://hg.csswg.org/test/rev/f304f0e56580
https://hg.csswg.org/test/rev/60b7afe295f8

Hajime.


2015-07-19 3:27 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:

> Le 2015-07-18 11:31, 塩澤 元 a écrit :
>
>> Gérard,
>>
>> I've submitted the new reference files.
>> https://hg.csswg.org/test/rev/219e6caa0a62
>>
>> I have not adjusted inline-block-alignment-new-009.xht and
>> inline-block-alignment-new-010.xht.
>> And I have created the new reference file for these two test case.
>> Is this right choice?
>>
>> Hajime.
>>
>
> Hajime,
>
>
> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-009.xht
>
> I think you are correct; that is a good catch. We need to use "p" glyphs.
> If we use "É" glyphs, then there must be a blank space (white gap == 0.2em
> wide) between the last line box of the inline-block and the first line box
> (<span class="block-descendant">B</span>).
>
> line 52: ... if the <strong>left edge</strong> of an ...
>
> should be
>
> line 52: ... if the <strong>right edge</strong> of an ...
>
>
> - - - - - - - -
>
>
>
> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-010.xht
>
> I think you are correct. We need to use "p" glyphs in this test too. If we
> use "É" glyphs, then there must be a blank space (white gap == 0.2em wide)
> between the last line box of the inline-block and the first line box (<span
> class="block-descendant">B</span>).
>
> line 52: ... if the <strong>right edge</strong> of an ...
>
> should be
>
> line 52: ... if the <strong>left edge</strong> of an ...
>
>
> - - - - - - -
>
> Are you going to filename-rename those tests and remove "-new" from those
> and in that serie of tests?
>
> Gérard
>
>
>
>
>  2015-07-17 9:29 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
>>
>>  Le 2015-07-15 19:58, 塩澤 元 a écrit :
>>>
>>>  Gérard,
>>>>
>>>> I have submitted.
>>>>
>>>> https://hg.csswg.org/test/rev/74cf2d8eb799
>>>>
>>>>
>>>>
>>>>  Hajime,
>>>
>>>  5-
>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-009.xht
>>>>>
>>>>> I believe inline-block-alignment-new-009.xht's reference file should be
>>>>>
>>>>> inline-block-alignment-new-007-ref.xht and not
>>>>> inline-block-alignment-new-006-ref.xht
>>>>>
>>>>> and inline-block-alignment-new-009's pass-fail-conditions should be
>>>>>
>>>>> <p>Test passes if the <strong>right edge</strong> of an irregular
>>>>> polygon
>>>>> is straight and unbroken.</p>
>>>>>
>>>>> and not left edge.
>>>>>
>>>>>
>>>>>
>>>>>  Your
>>> InlineBlockAlphabeticalAlignment.PNG
>>> re-attached to this email confirms my opinion:
>>>
>>> inline-block-alignment-new-009.xht's reference file should be
>>> inline-block-alignment-new-007-ref.xht
>>> and not
>>> inline-block-alignment-new-006-ref.xht
>>>
>>> Please adjust inline-block-alignment-new-009.xht accordingly.
>>>
>>>  6-
>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-010.xht
>>>>>
>>>>> I believe inline-block-alignment-new-010.xht's reference file should be
>>>>>
>>>>> inline-block-alignment-new-006-ref.xht and not
>>>>> inline-block-alignment-new-007-ref.xht
>>>>>
>>>>> and inline-block-alignment-new-010's pass-fail-conditions should be
>>>>>
>>>>> <p>Test passes if the <strong>left edge</strong> of an irregular
>>>>> polygon
>>>>> is straight and unbroken.</p>
>>>>>
>>>>> and not right edge.
>>>>>
>>>>>
>>>>
>>> Your
>>> InlineBlockAlphabeticalAlignment.PNG
>>> re-attached to this email confirms my opinion:
>>>
>>> inline-block-alignment-new-010.xht's reference file should be
>>> inline-block-alignment-new-006-ref.xht
>>> and not
>>> inline-block-alignment-new-007-ref.xht
>>>
>>>
>>> Please adjust inline-block-alignment-new-010.xht accordingly.
>>>
>>>
>>>  Now I have another thought. Now I think that the reference files must
>>> have
>>>
>>>> four pattern for alphabetical baseline testcase.
>>>>
>>>> - (1) vertical-rl + sideways-right (= vertical-rl + sideways)
>>>> - (2) vertical-rl + sideways-left
>>>> - (3) vertical-lr + sideways-right
>>>> - (4) veritcal-lr + sideways-left (= vertical-lr + sideways)
>>>>
>>>> I've attached the image which represents above all pattern.
>>>> In the image, "ABCDEFG" is the first line in inline-block, "HIJKLMN" is
>>>> the
>>>> last line in inline-block.
>>>>
>>>> What do you think about?
>>>>
>>>>
>>>
>>> I agree with your InlineBlockAlphabeticalAlignment.PNG (under current
>>> spec) but...
>>>
>>> 'writing-mode: sideways-left'
>>>
>>> has a good chance of being adopted by CSSWG ... and then
>>> 'text-orientation: sideways-left' would be dropped according to
>>>
>>> http://lists.w3.org/Archives/Public/www-style/2015Jul/0060.html
>>>
>>>
>>> Gérard
>>> --
>>> Test Format Guidelines
>>> http://testthewebforward.org/docs/test-format-guidelines.html
>>>
>>> Test Style Guidelines
>>> http://testthewebforward.org/docs/test-style-guidelines.html
>>>
>>> Test Templates
>>> http://testthewebforward.org/docs/test-templates.html
>>>
>>> CSS Naming Guidelines
>>> http://testthewebforward.org/docs/css-naming.html
>>>
>>> Test Review Checklist
>>> http://testthewebforward.org/docs/review-checklist.html
>>>
>>> CSS Metadata
>>> http://testthewebforward.org/docs/css-metadata.html
>>>
>>>
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>



-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com
Received on Sunday, 19 July 2015 03:01:21 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:21 UTC