W3C home > Mailing lists > Public > public-css-testsuite@w3.org > July 2015

Re: fixed new inline-block alignement test

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Sun, 05 Jul 2015 15:30:24 -0400
To: 塩澤 元 (Shiozawa, Hajime) <hajime.shiozawa@gmail.com>
Cc: Koji Ishii <kojiishi@gluesoft.co.jp>, Public CSS test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <d0f729d41750c12740c348498bd939f9@gtalbot.org>
Le 2015-07-05 02:25, 塩澤 元 a écrit :
> Gérard,
> 
> I have fixed the inline-block alignement test in reference to your
> review^[1]
> 
> https://hg.csswg.org/test/rev/4d6bad11f62e
> 
> Could you review it?
> 
> After your review and approval, I will create other variation of
> inline-block alignment.
> 
> [1]:
> http://lists.w3.org/Archives/Public/public-css-testsuite/2015Jun/0007.html
> 
> Hajime.

Here is what I came up with:

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/inline-block-alignment-new-002-Hajime.xht

Your test:
http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-002.xht

1- (line 15 in your test)
It's always safer to use a numerical line-height (1) instead of a 
font-size (1em) because computed line-height is inherited by default; a 
numerical line-height will scale with relevant font-size. In your test, 
1em was okay since other inline boxes were taller.

2- (lines 24 and 25 in your test)
Creating an asymetrical vertical padding on inline boxes can better 
reveal an implementation bug.
I've added a /* comment */ explaining the purpose of such logical 
vertical padding

3- (line 26 in your test)
I've removed color: fuchsia.

4- (line 33 in your test)
Since line-height is inherited, then you do not need to redeclare it for 
its descendants.

5- (lines 36 and 41 in your test)
I've used id instead of classes for first-line-box and last-line-box

6- (lines 49 and 50 in your test)
Asymetrical vertical padding on that inline plus a /* comment */

If you now load that test into the latest most recent Firefox 42 nightly 
build, you can see 2 bugs occuring. The left padding and right padding 
on the inline boxes should not affect baseline alignment of text (the 
horizontal position of those orange squares with respect to the blue 
square) on the dominant baseline... whatever such dominant baseline is 
and however how baseline-alignment is implemented.

Adapted reference file:
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/inline-block-alignment-new-002-Hajime-ref.xht

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Sunday, 5 July 2015 19:30:56 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:21 UTC