- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Wed, 18 Feb 2015 00:40:32 -0500
- To: Mihai Balan <mibalan@adobe.com>
- Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Mihai, http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/extract-ordered-list-direction-and-writing-modes.htm I examined your test and I suggest you break it into 3 smaller tests, at least, to start with. [Maybe you have done so: I don't know this for sure... as there are already many tests beginning with the filename 'extract-ordered-lists-in-regions' in §3.1 of regions test suite.] Otherwise you should make such test easier to figure out for people taking the test and eventual reviewers and less complex. That test uses nested lists (why nested lists?), regions are floated (is that really necessary?), uses flow-into, flow-from, region-break-after (deprecated?), break-after, direction: rtl and vertical writing-modes. It looks like a complex test and a difficult test to pass for any browser. When you link to a spec, it's better to link from the table of contents rather than the property definition. " Links should link to relevant sections within the specification Use the anchors from the specification's Table of Contents " http://testthewebforward.org/docs/css-metadata.html#specification-links It seems to me that 'region-break-after' has been superceded in 2013. Just having a test testing solely, only 'break-after: region' would be, by itself, probably needed here as there seems to be no test on 'break-after: region' in CSS3 Fragmentation or in CSS3 Regions test suite: http://test.csswg.org/suites/css-regions-1_dev/nightly-unstable/html/chapter-3.htm#s3.3 The pass-fail-conditions sentences are over 1 KiloByte. The reference file presumes that browsers taking the test will support 'direction: rtl' and 'vertical-rl' and 'vertical-lr' writing-modes ... which is not always a reliable, trustworthy method of creating reference files. There must be reasons why you created this test; I just believe this test as is is not suitable for the writing-mode test suite. I suggest testing 1 region and 1 writing-mode at a time in 1 - as simple and short as possible - test. Gérard -- Test Format Guidelines http://testthewebforward.org/docs/test-format-guidelines.html Test Style Guidelines http://testthewebforward.org/docs/test-style-guidelines.html Test Templates http://testthewebforward.org/docs/test-templates.html CSS Naming Guidelines http://testthewebforward.org/docs/css-naming.html Test Review Checklist http://testthewebforward.org/docs/review-checklist.html CSS Metadata http://testthewebforward.org/docs/css-metadata.html
Received on Wednesday, 18 February 2015 05:41:05 UTC