W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2015

[css-writing-modes-3] value-digits4-003 tests

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Tue, 17 Feb 2015 01:13:41 -0500
To: Masataka Yakura <masataka.yakura@gmail.com>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <a8eaee5ea4ece5bf3ea8cda4d1e1a255@gtalbot.org>
Masataka,

http://test.csswg.org/source/css-writing-modes-3/text-combine-upright/value-digits4-003.html

Several text-combine-upright (tate-chu-yoko) tests you did are excellent 
although
some are rather long and forces scrolling up and down when taking the 
test harness.



By default, p elements have this rule from user agent style sheet:

p {margin: 1em 0;}

"
Beware! <p> has margins by default!
"
https://wiki.csswg.org/test/format#body-content

So, if font-size is 100px, then rendered content height may increase by 
200px just to render those black rectangles (or squares) if the browser 
has not logicalized margin-top as margin-start (like Firefox; but Chrome 
40 has). And we want tests to be taken with the test harness which uses 
about 400px tall.
Even in Chrome 40, it's still rather long: rendered content height is 
551px tall.

"
Tests should be as short as possible. For reftests in particular 
scrollbars at 800×600px window size must be avoided unless scrolling 
behaviour is specifically being tested.
"
http://testthewebforward.org/docs/test-format-guidelines.html#short

By definition, "the X/HTML div element is assigned display: block; and 
no other property declaration."
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/#common

I suggest to change the code to use inner divs (instead of p) and to 
reduce the font-size to 5em (computes to 80px). 5em is also more 
scalable, less rigid than px unit.


line 11: <style>
div#test {
   writing-mode: vertical-rl;
   font: 5em/1 Ahem; /* computes to 80px/80px */
}

div > div {margin-right: 0.125em;} /* computes to 10px */

.tcy {
   text-combine-upright: digits 4;
}
</style>
</head>
<body>

<p>Test passes if there are 2 <strong>identical</strong> black 
rectangles.</p>

<div id="test">
   <div><span class="tcy">12345</span></div>
   <div>xxxxx</div>
</div>

------

Example given:

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/value-digits4-003-GT.html

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/vertical-ahem-1x5-GT-ref.html

In this case, your test would not require a mismatch reference to 
control support of writing-mode.

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Tuesday, 17 February 2015 06:14:11 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:20 UTC