W3C home > Mailing lists > Public > public-css-testsuite@w3.org > December 2015

Re: [css-writing-modes-3] Review of orthogonal-parent-shrink-to-fit-001[a-x]

From: Koji Ishii <kojiishi@gmail.com>
Date: Thu, 24 Dec 2015 22:50:05 +0900
Message-ID: <CAN9ydbXvJCzhjhcburZ+Y2mDFCCfT31RdLCrEcuwWjnvS7A78Q@mail.gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>, Koji Ishii <kojiishi@gluesoft.co.jp>
Thank you Gérard, all confirmed, and I’ve updated the combo one too accordingly.


/koji

2015-12-23 23:51 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
> Koji,
>
> I reviewed your 24 orthogonal-parent-shrink-to-fit-001[a-x] tests.
>
> http://hg.csswg.org/test/rev/ee0eb93a23b4
>
> Changes I made:
>
> 1- Added <meta charset="utf-8">
>
> 2- Added title="7.3. Orthogonal Flows"
>
> 3- Added dom flag
>
> 4- Added /* height: 3em is not required. IE11 and Edge12 compute height to
> ICB height if
>     not set. We want the test to focus exclusively on shrink-to-fit
> algorithm. */
>
> 5- XX or XXX have been replaced with HH or HHH; YY has been replaced with ZZ
> . The idea here is, if reviewer disables Ahem font and uses font-family:
> serif, then the glyphs themselves will help a bit to see where their
> respective edges are displayed.
>
>
> Note that:
> - float: right is not tested in those 24 tests
> - vertical-lr is not tested in those 24 tests
> - table elements are not tested in those 24 tests (I may have some tests
> ready on that)
> - inline-table elements are not tested in those 24 tests
> - orthogonal-parent-shrink-to-fit-001 has not been reviewed for several
> reasons; I think we should remove such orthogonal-parent-shrink-to-fit-001
> combo test.
>
> http://hg.csswg.org/test/rev/ee0eb93a23b4
>
> Gérard
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>
Received on Thursday, 24 December 2015 13:50:53 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:21 UTC