- From: Florian Rivoal <florian@rivoal.net>
- Date: Tue, 28 Apr 2015 13:35:47 +0200
- To: "L. David Baron" <dbaron@dbaron.org>, fantasai <fantasai.lists@inkedblade.net>, sjohnson@mozilla.com, public-css-testsuite@w3.org
- Cc: Boris Zbarsky <bzbarsky@MIT.EDU>
Hi Scott, Fantasai and David, (Sending to you because you are marked in shepherd either as author or owner of the TCs) Since the box-sizing section of css3-ui has now stabilized, I've reviewed the test cases that Mozilla has contributed to the w3c for box-sizing. Sorry about the long delay between submission and review. http://test.csswg.org/shepherd/search/testcase/spec/css-ui-3/owner/dbaron While they are all correct, they also all need improvements. Most of the TC are not minimized and use quite a bit more markup and style than needed for what they are testing. They also use an unusual look for the PASS state, while they could easily be made into the typical 100*100px green square with no red. Also, they are not reftests even though they easily could be. See this comment on box-sizing-border-box-001 for a representative example of what I'm talking about: http://test.csswg.org/shepherd/testcase/box-sizing-border-box-001/spec/css-ui-3/owner/dbaron/#comment-432e47396122 I've marked all the TCs as "needs work", with comments in each saying why. I would have fixed them myself, but: 1) They are synced from mozilla's repo, so they should probably be fixed upstream, and I don't have write access there 2) I cannot close this alone anyway, since we'd need to find someone else to be the reviewer if I became an author. - Florian
Received on Tuesday, 28 April 2015 11:36:13 UTC