- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sun, 09 Nov 2014 01:18:17 -0500
- To: Masataka Yakura <myakura.web@gmail.com>
- Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Masataka, http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/full-width-002.htm http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/reference/full-width-horizontal-notref.htm I am wondering if the mismatching reference full-width-horizontal-notref is relevant or necessary here. If and since text-combine-upright property "only has an effect in vertical writing modes", then full-width-horizontal-notref does not seem to me to be usefulness as a mismatch of full-width-002 test. On the other hand, as a test verifying that text-combine-upright property "only has an effect in vertical writing modes", yes, full-width-horizontal-notref would be useful. --------- http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/full-width-002.htm <style> .test { writing-mode: vertical-rl; } .tcy, .tcu-all { text-combine-upright: all; } .tcy { text-transform: full-width; } (...) line 30: <div class="test"> <p><span class="tcy">6</span>月<span class="tcy">19</span>日</p> <p>6月<span class="tcu-all">19</span>日</p> </div> Suggested code modifications ---------------------------- <style> div { writing-mode: vertical-rl; } .full-width, .tcu-all { text-combine-upright: all; } .full-width { text-transform: full-width; } (...) <div> <p id="test"><span class="full-width">6</span>月<span class="full-width">19</span>日</p> <p id="reference">6月<span class="tcu-all">19</span>日</p> </div> With these modifications, I think the test would be a bit more understandable and easier to maintain. Gérard -- Test Format Guidelines http://testthewebforward.org/docs/test-format-guidelines.html Test Style Guidelines http://testthewebforward.org/docs/test-style-guidelines.html Test Templates http://testthewebforward.org/docs/test-templates.html CSS Naming Guidelines http://testthewebforward.org/docs/css-naming.html Test Review Checklist http://testthewebforward.org/docs/review-checklist.html CSS Metadata http://testthewebforward.org/docs/css-metadata.html
Received on Sunday, 9 November 2014 06:18:55 UTC