W3C home > Mailing lists > Public > public-css-testsuite@w3.org > June 2014

Re: CSS test repo refactored - branch ready for review

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Mon, 02 Jun 2014 20:49:58 -0400
To: Rebecca Hauck <rhauck@adobe.com>
Cc: Peter Linss <peter.linss@hp.com>, public-css-testsuite@w3.org
Message-ID: <72d5065b123f2695374953dc48b82718@gtalbot.org>
Le 2014-06-02 16:58, Rebecca Hauck a écrit :
> [Š]
> 
>>> 
>>> 2-
>>> Many things do not seem right... or at least they're odd.
>>> 
>>> a) This folder
>>> 
>>> http://test.csswg.org/source/css21/reference/
>>> 
>>> now contains various reference files *and* very frequently used and
>>> reused reference files (with their filename starting with "ref-" eg
>>> ref-filled-black-96px-square.xht). I do not believe this is best or 
>>> even
>>> intended.
>> 
>> Rebecca handled all the actual refactoring, but I agree, the common
>> reference files should probably be moved into a 'reference' directory 
>> in
>> the root of the repository. Note that all the reference links to those
>> files will have to be updated as well.
> 
> To keep things simple for this initial refactoring,

Rebecca,

Okay... so I should be assuming that refactoring is not complete right 
now...

> I moved everything
> from */submitted into the spec directory according the the top spec 
> link
> in the tests

About ~=260 of my tests ... which were in contributors/gtalbot/submitted 
are now at the root of
http://test.csswg.org/source/css21/
and, in my humble opinion, they should not be. These ~=260 tests should 
be moved into spec directory according the the top spec link in the 
tests.

> and if there were /reference subfolders where the tests
> lived, I moved the contents to spec-folder/reference.

Several reference files for those ~=260 tests are now in
http://test.csswg.org/source/css21/reference/

> As you point out in
> other areas, things could be audited and organized a bit more to remove
> unnecessary and duplicate files and I¹m working on some scripts to help
> with that.  Keep in mind that all of these files were already in the 
> repo
> in various places so the issues you¹re pointing out already existed, 
> just
> from different locations.
> 
> 
>> 
>>> 
>>> 
>>> b) About 260 tests that I submitted have been moved to an odd folder,
>>> to the root folder
>>> Eg.#1
>>> absolute-non-replaced-width-025
>>> should be in folder
>>> http://test.csswg.org/source/css21/visudet/
>>> but it isn't. According to shepherd, such test (and =~ 259 other 
>>> tests)
>>> is in the root folder:
>>> http://test.csswg.org/source/css21/
>> 
>> I don't think that rearranging the subdirectories within the
>> specification directories was part of this refactoring. If we're going 
>> to
>> be consistent with the WPT repo then we may have to rethink that 
>> anyway
>> (though I don't think having a directory structure tied to spec
>> subsections is a good idea for specs under active development, as the
>> structure of the specs tends to change a lot and it's too much to
>> rearrange the test repo every time that happens).
> 
> Right. For the first pass, I didn¹t go as far to organize 
> subdirectories.
> Those that were there, I left intact and the tests that lived elsewhere 
> in
> those categories just got moved to the root. Again, the tests that
> probably belong in those subdirectories weren¹t in them before the
> refactor and now they¹re just a little closer to where they ought to 
> be.

I'm trying to understand all this ...

> 
> 
>> At this point feel free to move your tests about if you don't think
>> they're in the right place, just be sure to either update the paths to
>> reference and support files or move them as well, as needed.
> 
> Yes, I agree. If you want to organize these a bit more, feel free. 
> Please
> do so directly in Mercurial

Okay. So, I should manually move those ~=260 tests into their 
appropriate spec folder thanks to Mercurial, right? Along with their 
associated reference files in
http://test.csswg.org/source/css21/reference/
this could be a huge job.


> and not through a github PR. We¹ve learned
> that the latter will not preserve the history when merged from the 
> github
> mirror to the the canonical HG repo.
> 
>> 
>>> 
>>> Eg.#2
>>> I have 29 background-position-* tests in
>>> http://test.csswg.org/source/css21/
>>> which obviously should be instead in
>>> http://test.csswg.org/source/css21/backgrounds/
> 
> Feel free to move them there - I believe they previously existed in 
> your
> submitted folder.

Yes, they were previously in my submitted folder.

(...)

> Please do let me know about other
> weird things you notice and certainly feel free to fix them as you see 
> fit.

Well, I'd like to get your okay on the modifications proposal (detailed 
in my other email) on the run-in tests which are scattered in the spec 
folders of
http://test.csswg.org/source/css21/

Gérard
-- 
Web authors' contributions to CSS 2.1 test suite
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
CSS 2.1 Test suite RC6, March 23rd 2011
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html
Received on Tuesday, 3 June 2014 00:50:38 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:20 UTC