- From: taka <takaoshiyama@gmail.com>
- Date: Sun, 17 Feb 2013 20:34:19 +0900
- To: public-css-testsuite@w3.org
Hi Gerard I respond with this thread as your mail below to be directed here: -> http://lists.w3.org/Archives/Public/public-css-testsuite/2013Feb/0046.html Please review here again, thanks. -> http://hg.csswg.org/test/rev/e2ceb488d9f7 > line 5: > <title>CSS3 Writing Modes Test: text-combine-horizontal</title> > > I suggest > > <title>CSS Writing Modes Test: text-combine-horizontal - none</title> > > Nota bene: it should be CSS and not CSS3; we will want to reuse this > test if/when there will be a CSS4 writing mode specification. > > One good method of writing title text in a consistent and predictable > manner is: > > <title>CSS [Name_of_module] Test: [property_name] - [property_value] > [optional: some_additional_parameters]</title> > Thanks, I agree. I corrected each. > ------------- > > line 11: > <meta name="flags" content="" /> > > Since your tests are requiring special, specific fonts, do not forget to > add the font flag. Thanks, I agree. I corrected each. > ------------- > > line 12: > <meta name="assert" content="This property allows the combination of > multiple characters into the space of a single character ." /> > > The assert text describes the goal of the test, what it is testing. > > One good method of writing the text assert in a consistent and > predictable manner is: > > <meta name="assert" content="This test checks, verifies that > [property_name]: [property_value] with [some_additional_parameters] does > [expected_results]." /> > > So, here, I would suggest: > > <meta name="assert" content="This test checks, verifies that > 'text-combine-horizontal: none' does not combine multiple characters > into the space of a single character." /> Thanks, I agree. I corrected each. > -------------- > > line 39: > text-orientaion: mixed; > should be > text-orientation: mixed; Thanks, I corrected typo. > ------------- > > line 50: > <span class="tcy">1</span>月<span > class="tcy">2</span>日の次の日は、<br > /><span class="tcy">1</span>月<span class="tcy">3</span> > > Maybe I'm wrong here but... why is there no span with more than 1 > character.. Shouldn't that be necessary in the test? Shouldn't that be > what would be need to be tested? In this test, I address a single digit numeric characters one by one. (ideally I would like to handle multiple digits such as '2013' to be 'text-combine-horizontal: all', but unfortunately no stable rendering techniques for a reference is found.) > -------------- > > line 50: > class attribute versus id attribute > > Class attribute is best used for logical grouping of many elements; > semantically speaking, this was the genuine design intent for HTML. > > id attribute is best used for one single element in a document. > > So, a bit better is > > <div id="test"> ... </div> > > <div id="control"> ... </div> Thanks, I agree. I corrected each. -- taka oshiyama 押山 隆 takaoshiyama@gmail.com
Received on Sunday, 17 February 2013 11:34:53 UTC